Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

how do I make the subtitles name the same as the video file name when downloading subtitles? #785

Open
candrapersada opened this issue Nov 11, 2023 · 4 comments

Comments

@candrapersada
Copy link

No description provided.

@cipricus
Copy link

I guess this should count as a feature request.

@tomasklaen
Copy link
Owner

You want the subtitle filename to match the video filename? I don't like this. If I download 2 different subtitles I want to be able to identify them. Also if I download bad/not-matching subtitles, I don't want them to be named exactly as the file, suggesting they match. You're also stripping potential translator credentials from filenames, which is not a nice thing to do.

@cipricus
Copy link

cipricus commented Nov 12, 2023

I thought it to be a pre-condition for the auto-load part, but I get it now. Also, while I understand your reasons, both VLC and SMPlayer do rename the subs according to the video name, which might make them a better alternative. I am trying personally to use mpv exclusively and the only reason why I didn't was the subs download.

I like very much the smplayer interaction (the same as mpc-hc in Windows) with a list of subs that stays open until I close it, so I don't have to re-do the 4-time button-clicking for every sub.

@cipricus
Copy link

cipricus commented Nov 13, 2023

You want the subtitle filename to match the video filename? I don't like this. If I download 2 different subtitles I want to be able to identify them. Also if I download bad/not-matching subtitles, I don't want them to be named exactly as the file, suggesting they match. You're also stripping potential translator credentials from filenames, which is not a nice thing to do.

  • Normally a good subtitle is expected to be loaded automatically, and that normally happens if it has the same name as the movie. So, people will rename it manually anyway, so why not do it automatically? - The smoothest and most frequently expected way of getting subtitles is to have them quickly listed, download one and test it, and, in case it doesn't fit, the next is to be tried (and that is what we have in VLC, SMPlayer, MPC-HC). This can happen many times. If the last one (last because good) doesn't replace the previous ones (that were proven to be bad), in the end the user ends up with a bunch of files with different names that don't clearly indicate which one is good and which have to be deleted.
  • The need for more than one subtitle in the same language is less frequent than the above, and in that case renaming manually makes more sense.
  • When subtitles in different languages are needed: isn't it possible to append language code to the subtitle, like SMPlayer does? - And, again, renaming manually makes more sense here than in the first case above.
  • Translator credentials are seen in the list of subtitles anyway and, above all, what most users will do anyway will be to rename the file manually. (And, to be honest, if I will have to keep renaming files, beside having to re-test all downloaded subs, I don't think I will do that instead of simply using SMPlayer or VLC in the first place for the purpose of getting subtitles. But I would surely love to get subtitles with my favorite player!)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants