Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Option to place timeline_cache on the controls bar #885

Open
Solarunit opened this issue Apr 22, 2024 · 6 comments
Open

Option to place timeline_cache on the controls bar #885

Solarunit opened this issue Apr 22, 2024 · 6 comments

Comments

@Solarunit
Copy link

I wish there was an option to put timeline_cache to the controls bar.
IIRC it's the default position in stock UI.

@christoph-heinrich
Copy link
Contributor

Can you draw a rough mock up or something of what you're imagining? I have a hard time picturing what that would be like.

@Solarunit
Copy link
Author

Sure

@Solarunit
Copy link
Author

Something similar to stock UI:

mpv-cache

it could be with Cache: text or without it.

@christoph-heinrich
Copy link
Contributor

Oh that's what you mean.

IDK about showing it in the controls bar, it's not a great fit there with all the configurable buttons and such, but let's see what others have to say about that.

@tomasklaen
Copy link
Owner

If my suggestion in #886 ever lands, you should be able to just disable timeline cache in timeline, and put something like demuxer-cache-time in the mentioned meta element's template.

Other than that, I don't see a reason for different cache position. I'm fine with current one, and can't imagine a good alternative. Above controls bar is not an option, and content of controls bar is completely in hands of users, so it can't be affected by timeline options.

@Solarunit
Copy link
Author

I think the current implementation is not bad and i kinda like that it moves along with the progress bar, this is cool.

But I see some cons:

  1. It's not static, so you can't detect it immediately like static one in stock UI.
  2. It interferes a bit with start and end timers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants