Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prefer tag annotation #7

Open
mbrodala opened this issue Jan 21, 2021 · 5 comments
Open

Prefer tag annotation #7

mbrodala opened this issue Jan 21, 2021 · 5 comments
Labels
enhancement New feature or request

Comments

@mbrodala
Copy link

Currently this action uses the last Git log entry as upload comment. Considering this message will very likely be a regular commit adhering to the TYPO3 CGL it could be something like [TASK] Doing foo or [RELEASE] Raise version to x.y.z. Such a comment is less useful in the TER version list.

Instead, the annotation of the currently processed tag should be preferred which can be retrieved like this:

git tag -l --format='%(contents)' x.y.z
@tomasnorre
Copy link
Owner

Thanks for your sugestion @mbrodala, I'll look into this.

I've done it like this as we do release commit for the crawler like this:

[RELEASE] Crawler version 9.2.1

Changed
* Moved HTML from the LogRequestForm->drawLog_addRows() to Fluid-template
* Extended the Example for PageTS Configuration

Deprecated Functions
* SignalSlotUtility->emitSignal()

Deprecated Classes
* SignalSlotUtility

Fixed
* PageTS Crawler configurations (broken since 9.1.3) 

But will check how it will looks like in your suggestion.

@tomasnorre tomasnorre added the enhancement New feature or request label Jan 21, 2021
@mbrodala
Copy link
Author

Notice that my suggestion only works for annotated tags, not lightweight tags. So a plain git tag x.y.z won't do, one must use git tag x.y.z -m "Tag annotation message".

@tomasnorre
Copy link
Owner

I see..

Do you have an example how a message like that would look like then, because as you wrote yourself [RELEASE] Raise version to x.y.z would be that helpful.

I never considered the Annotated Tags to be honest.

But perhaps making a check if it's an Annotated tag, then use it, if not fallback to regular tag.

@mbrodala
Copy link
Author

Here's a live example:

Improve handling of nested finisher variables
[RELEASE] Raise version to 1.3.4

Improve handling of nested finisher variables.

@tomasnorre
Copy link
Owner

Thanks, will look into it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants