Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

database overview: list_models() and verbosity control? #80

Closed
gabrielastro opened this issue Jan 26, 2024 · 4 comments
Closed

database overview: list_models() and verbosity control? #80

gabrielastro opened this issue Jan 26, 2024 · 4 comments
Labels
enhancement New feature or request

Comments

@gabrielastro
Copy link

Looking at https://species.readthedocs.io/en/latest/database.html, there is database.list_content() to print everything, and there exists database.list_companions(). But what about listing just the models available? Also it might be nice to have a verbosity flag to all these methods. The current output can be a bit massive (and thus not much of an overview), which is not always desired.

@tomasstolker tomasstolker added the enhancement New feature or request label Jan 29, 2024
@tomasstolker
Copy link
Owner

Thanks for the suggestion! In commit 001aef6, I have added the verbose parameter to list_companions and available_models. The latter method of Database can be used to list the available model spectra. For list_content I find a verbose parameter not so useful.

@gabrielastro
Copy link
Author

gabrielastro commented Jan 30, 2024

Ok, thanks! I tried it out and it is practical.

Tiny thing: strip the /abstract from the NASA ADS (just visual noise and not needed) 🤓 and maybe uniformise to have an empty line after all entries, not only those with an URL:

 …
      - Reference: Linder et al. (2019)
      - URL: https://ui.adsabs.harvard.edu/abs/2019A%26A...623A..85L/abstract

   - Saumon & Marley (2008) clear:
      - Label = saumon2008-clear
      - Model parameters: ['teff', 'logg']
      - Teff range (K): [500, 2400]
      - Wavelength range (um): [0.4, 50]
      - Resolution lambda/Dlambda: 5000
      - File size: 197 Mb
   - Saumon & Marley (2008) cloudy:
      - Label = saumon2008-cloudy
      - Model parameters: ['teff', 'logg']
…

Well, actually, except maybe for the blackbody, I guess every entry needs a URL for the reference 😁.

@tomasstolker
Copy link
Owner

Thanks for testing! The other suggestions have been fixed in commit bc6a4d3

@gabrielastro
Copy link
Author

Excellent, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants