fix(test): add SettingsModule import to examples component tests, tes…

…ts code style and improvements

src/app/app.component.spec.ts

@@ -1,8 +1,6 @@
 import { TestBed, async } from '@angular/core/testing';
-import { RouterTestingModule } from '@angular/router/testing';
-import { NoopAnimationsModule } from '@angular/platform-browser/animations';
 
-import { SharedModule } from '@app/shared';
+import { TestingModule } from '@testing/utils';
 import { CoreModule } from '@app/core';
 
 import { AppComponent } from './app.component';
@@ -11,12 +9,7 @@ describe('AppComponent', () => {
   beforeEach(
     async(() => {
       TestBed.configureTestingModule({
-        imports: [
-          NoopAnimationsModule,
-          RouterTestingModule,
-          SharedModule,
-          CoreModule
-        ],
+        imports: [CoreModule, TestingModule],
         declarations: [AppComponent]
       }).compileComponents();
     })

src/app/core/local-storage/local-storage.service.spec.ts

@@ -37,10 +37,17 @@ describe('LocalStorageService', () => {
     });
   });
 
-  it('should load nested initial state with camel case properties and object value', () => {
-    service.setItem('TEST.PROP.SUB-PROP', 'value');
+  it('should load initial state with camel case property', () => {
+    service.setItem('TEST.SUB-PROP', 'value');
     expect(LocalStorageService.loadInitialState()).toEqual({
-      test: { prop: { subProp: 'value' } }
+      test: { subProp: 'value' }
+    });
+  });
+
+  it('should load nested initial state with camel case properties', () => {
+    service.setItem('TEST.SUB-PROP.SUB-SUB-PROP', 'value');
+    expect(LocalStorageService.loadInitialState()).toEqual({
+      test: { subProp: { subSubProp: 'value' } }
     });
   });
 });

src/app/examples/examples/examples.component.spec.ts

@@ -2,6 +2,7 @@ import { async, ComponentFixture, TestBed } from '@angular/core/testing';
 
 import { CoreModule } from '@app/core';
 import { TestingModule } from '@testing/utils';
+import { SettingsModule } from '@app/settings';
 
 import { ExamplesComponent } from './examples.component';
 
@@ -12,7 +13,7 @@ describe('ExamplesComponent', () => {
   beforeEach(
     async(() => {
       TestBed.configureTestingModule({
-        imports: [TestingModule, CoreModule],
+        imports: [TestingModule, CoreModule, SettingsModule],
         declarations: [ExamplesComponent]
       }).compileComponents();
     })

src/app/examples/form/components/form.component.spec.ts

@@ -1,29 +1,42 @@
 import { async, ComponentFixture, TestBed } from '@angular/core/testing';
+import { Store } from '@ngrx/store';
 
-import { TestingModule } from '@testing/utils';
+import { MockStore, TestingModule } from '@testing/utils';
 
+import { State } from '../../examples.state';
+import { FormState } from '../form.model';
+import { initialState } from '../form.reducer';
 import { FormComponent } from './form.component';
 
 describe('FormComponent', () => {
   let component: FormComponent;
   let fixture: ComponentFixture<FormComponent>;
+  let store: MockStore<State>;
 
   beforeEach(
     async(() => {
       TestBed.configureTestingModule({
         imports: [TestingModule],
         declarations: [FormComponent]
       }).compileComponents();
+
+      store = TestBed.get(Store);
+      store.setState(createState(initialState));
+      fixture = TestBed.createComponent(FormComponent);
+      component = fixture.componentInstance;
+      fixture.detectChanges();
     })
   );
 
-  beforeEach(() => {
-    fixture = TestBed.createComponent(FormComponent);
-    component = fixture.componentInstance;
-    fixture.detectChanges();
-  });
-
   it('should create', () => {
     expect(component).toBeTruthy();
   });
 });
+
+function createState(formState: FormState) {
+  return {
+    examples: {
+      form: formState
+    }
+  } as State;
+}

src/app/examples/form/form.reducer.spec.ts

@@ -1,12 +1,9 @@
-import { FormState, Form } from './form.model';
+import { Form } from './form.model';
 import { formReducer, initialState } from './form.reducer';
-import {
-  ActionFormUpdate,
-  ActionFormReset
-} from '@app/examples/form/form.actions';
+import { ActionFormUpdate, ActionFormReset } from './form.actions';
 
 describe('FormReducer', () => {
-  const newForm: Form = {
+  const form: Form = {
     username: 'test',
     password: 'test',
     email: 'test@test.test',
@@ -23,14 +20,16 @@ describe('FormReducer', () => {
   });
 
   it('should update the form', () => {
-    const action = new ActionFormUpdate({ form: newForm });
+    const action = new ActionFormUpdate({
+      form: { ...form, username: 'updated' }
+    });
     const state = formReducer(initialState, action);
-    expect(state.form).toEqual(jasmine.objectContaining(newForm));
+    expect(state.form.username).toBe('updated');
   });
 
   it('should reset the form', () => {
     const action = new ActionFormReset();
-    const state = formReducer({ form: newForm }, action);
-    expect(state).toBe(initialState);
+    const state = formReducer(undefined, action);
+    expect(state).toEqual(initialState);
   });
 });

src/app/examples/stock-market/stock-market.service.spec.ts

@@ -1,14 +1,13 @@
 import { TestBed, inject } from '@angular/core/testing';
 import { RouterTestingModule } from '@angular/router/testing';
-
-import { CoreModule } from '@app/core';
+import { HttpClientModule } from '@angular/common/http';
 
 import { StockMarketService } from './stock-market.service';
 
 describe('StockMarketService', () => {
   beforeEach(() => {
     TestBed.configureTestingModule({
-      imports: [RouterTestingModule, CoreModule],
+      imports: [RouterTestingModule, HttpClientModule],
       providers: [StockMarketService]
     });
   });

src/app/examples/todos/components/todos-container.component.spec.ts

@@ -48,8 +48,8 @@ describe('TodosComponent', () => {
   beforeEach(
     async(() => {
       TestBed.configureTestingModule({
-        declarations: [TodosContainerComponent],
-        imports: [TestingModule]
+        imports: [TestingModule],
+        declarations: [TodosContainerComponent]
       }).compileComponents();
 
       store = TestBed.get(Store);

src/app/settings/components/settings-container.component.spec.ts

@@ -28,8 +28,8 @@ describe('SettingsComponent', () => {
   beforeEach(
     async(() => {
       TestBed.configureTestingModule({
-        declarations: [SettingsContainerComponent],
-        imports: [TestingModule]
+        imports: [TestingModule],
+        declarations: [SettingsContainerComponent]
       }).compileComponents();
 
       store = TestBed.get(Store);