Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix stock market example [Good for first time contributors] #136

Closed
tomastrajan opened this issue Apr 12, 2018 · 1 comment
Closed

Fix stock market example [Good for first time contributors] #136

tomastrajan opened this issue Apr 12, 2018 · 1 comment

Comments

@tomastrajan
Copy link
Owner

The stock market example was getting data from google finance API which seems to be discontinued. We have to find another free source of simple stock prices to consume and use it in stock-market.service.ts.

Based on the shape of retrieved data (JSON), additional adjustments to map functions might be needed.

Original Google finance API url: https://finance.google.com/finance?output=json&q=NYSE:

Tips for first time contributors:

  1. Create fork of the repository
  2. Create fix commit in format fix(examples): fix stock market API source or something similar
  3. Create pull request (Github) should offer that option automatically once the fix branch was pushed
@tomastrajan
Copy link
Owner Author

Was fixed by #162 by @shootermv, thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant