Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

crash during github sso due to email missing #51

Closed
ichernev opened this issue Aug 28, 2023 · 0 comments
Closed

crash during github sso due to email missing #51

ichernev opened this issue Aug 28, 2023 · 0 comments

Comments

@ichernev
Copy link

This line causes a crash sometimes: https://github.com/tomasvotava/fastapi-sso/blob/master/fastapi_sso/sso/github.py#L23C20-L23C37

It is more likely to happen if you do SSO with github with the same person multiple times in short succession (i.e more than 5 one after the other). The email seems to be missing (not sure about other fields). Ideally the code should use .get() instead of [].

I might post more data if I manage to capture the body.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant