Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don´t hard code the audio and video stream... #23

Closed
alex6dj opened this issue Oct 24, 2017 · 8 comments
Closed

Don´t hard code the audio and video stream... #23

alex6dj opened this issue Oct 24, 2017 · 8 comments
Assignees
Labels

Comments

@alex6dj
Copy link
Contributor

alex6dj commented Oct 24, 2017

Possibility to select the audio to use of those that exist in the original file, mainly for mkv.

@tomaszzmuda tomaszzmuda self-assigned this Oct 24, 2017
@tomaszzmuda
Copy link
Owner

This issue will take some time to be done.
I have to think about implementation but i'm sure it will change API so you will have to wait some time for it.

@alex6dj
Copy link
Contributor Author

alex6dj commented Oct 24, 2017

Okay, I know you did not think it that way and the changes are going to be many. By the way excellent work with this project. One of the things I'm anxiously waiting for is implementing a conversion queue ...

@tomaszzmuda
Copy link
Owner

Conversion queue look at this.
And thank you. It's meaning a lot for me :)

@alex6dj
Copy link
Contributor Author

alex6dj commented Oct 26, 2017

Okay, I was already checking the conversion queue. I know it's a preliminary version, but as a recommendation try to go a little further. For example the same could be done with a Parallel.Foreach without any complication.

First the example has an error, you declare the same variable 2 times and you use it only once. For me it is good as a basic example but maybe someone else does not understand it well and does not know wy it gives an error ...

I currently use this

https://github.com/huysentruitw/process-manager

In my personal case what I would need in a conversion queue (some things are not implemented in the one I use) ...

  • Possibility to start the queue and go adding jobs as needed.
  • Completely stop or pause the queue (this may be not processing more jobs until it restarts).
  • Maybe change the order of conversion or at least be able to give priority to certain works over others.
  • Reporting the progress of each conversion is already done.
  • Number of jobs in parallel (I see well that the number matches the processors count).
  • Change the priority of processes (ProcessPriorityClass.BelowNormal) to approve the processor to the maximum when not using the machine but not to disturb when using it (this would be an idea for each process).

If there is anything else I let you know ...

By the way my native language is Spanish. I read English well but, so I helped the translator google, in case there is something you do not understand ...

regards

@tomaszzmuda
Copy link
Owner

Thank you for listening what you need.
I'm going to do some of this today.
I would be glad if we could talk. Can you write to me at discord?

@alex6dj
Copy link
Contributor Author

alex6dj commented Oct 26, 2017

Sorry sometimes we are in the wrong part of the earth. I am Cuban so the internet is limited just like the pages I have access to. We have to try another solution. I do not complain but sometimes makes communication difficult.

@tomaszzmuda
Copy link
Owner

So give me way to contant you in private message :)

@alex6dj
Copy link
Contributor Author

alex6dj commented Oct 26, 2017

Ok already have an acount in discordapp.com, it´s new to me. So let´s speak.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants