You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Suggest this change for both calls.
I'm having both exe files in lower case and current solution gave me exception :(
btw. also it'll be good idea to wrap all this in try-catch block, because now if linq fails to find file with needed name in the user-provided dir it throws linq exception which is rather misleading in its place.
The text was updated successfully, but these errors were encountered:
I have done it.
Now name of executables are case insensitive and you can override default names in static fields in FFbase.
I've added more clear message if FFmpeg executables wasn't found.
Xabe.FFmpeg/Xabe.FFmpeg/FFbase.cs
Line 57 in c8cc423
Hi, it's me again. Suggest the following change:
.First(x => x.Name.Contains("ffprobe"))
.FullName;
.First(x => x.Name.Contains("FFmpeg"))
.FullName;
to:
private const string _MPEG_FILE_NAME = "ffmpeg";
private const string _PROBE_FILE_NAME = "ffprobe";
.First(x => x.Name.ToLower().Contains(_PROBE_FILE_NAME))
.FullName;
.First(x => x.Name.ToLower().Contains(_MPEG_FILE_NAME))
.FullName;
Suggest this change for both calls.
I'm having both exe files in lower case and current solution gave me exception :(
btw. also it'll be good idea to wrap all this in try-catch block, because now if linq fails to find file with needed name in the user-provided dir it throws linq exception which is rather misleading in its place.
The text was updated successfully, but these errors were encountered: