Provide an option to disable record splitting #588
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nmav
force-pushed
the
tmp-fix-1-1-split
branch
from
26c2b2e
to
05c956b
Compare
Some tests mandate record splitting although their primary test case is unrelated to it. This enables an implementation to use that test case even if it does not have record splitting.
nmav
force-pushed
the
tmp-fix-1-1-split
branch
from
05c956b
to
5e0ca64
Compare
tomato42
approved these changes
Sep 12, 2019
There was a problem hiding this comment.
Reviewed 5 of 5 files at r1.
Reviewable status:complete! all files reviewed, all discussions resolved
tomato42
added a commit
that referenced
this pull request
Sep 12, 2019
|
looks good, I've just tweaked the help message (as it could be interpreted as referring to the messages sent by the client, not the server) |
tomato42
added
the
maintenance
|
Thank you |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Some tests mandate record splitting although their primary test case is unrelated to it. This enables an implementation to use that test case even if it does not have record splitting.
This change is