Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CertificateRequest and CertificateVerify test coverage #11

Merged
merged 12 commits into from
Jun 10, 2015

Conversation

tomato42
Copy link
Member

@tomato42 tomato42 commented Jun 7, 2015

add unit tests for the above two messages

@tomato42
Copy link
Member Author

tomato42 commented Jun 7, 2015

commit e0f0fee and before are part of pull request #10

@landscape-bot
Copy link

Code Health
Repository health increased by 3% when pulling 82f8fe9 on cr-cv-cleanup into 984e4c1 on master.

@tomato42 tomato42 added the review request PR finished, ready for review label Jun 7, 2015
provide human-readable names for supported ciphersuites
describe which purpose have the different list of ciphers
fix pylint C0103 (invalid-name)
fixes pylint invalid-name and redefined-builtin
because the deserialise will write nothing if the cipherSuite is
set to None, we need to actually set it to one of the anonymous SRP
ciphersuites first

note that the TLSv1.2 signature handling is still incorrect!
fixes pylint C0303 (trailing-whitespace)
@landscape-bot
Copy link

Code Health
Repository health increased by 1% when pulling 21b6350 on cr-cv-cleanup into 95e2a3e on master.

tomato42 added a commit that referenced this pull request Jun 10, 2015
CertificateRequest and CertificateVerify test coverage
@tomato42 tomato42 merged commit 1682385 into master Jun 10, 2015
@tomato42 tomato42 deleted the cr-cv-cleanup branch June 10, 2015 10:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
review request PR finished, ready for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants