Chromium patches 2 fixed up #12
Closed
+1,051
−120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
@davidben: Hi! I reworked your patches a bit to address most of my complaints (mostly just the ones that were breaking tests). I'd be awesome if you could take a look and say what you think. Patches in question are 598283b, 51290a7 and d0de9f8. Feel free to review other patches too. Things left to fix:
Update: rebased on current cr-cv-cleanup, fixed up the patches while preserving authorship |
provide human-readable names for supported ciphersuites describe which purpose have the different list of ciphers
fix pylint C0103 (invalid-name)
fixes pylint invalid-name and redefined-builtin
because the deserialise will write nothing if the cipherSuite is set to None, we need to actually set it to one of the anonymous SRP ciphersuites first note that the TLSv1.2 signature handling is still incorrect!
fixes pylint C0303 (trailing-whitespace)
Adapted from a Chromium patch. This matches the other messages; __init__ gets passed parameters necessary to determine the behavior of parse (version, cipherSuite), while the fields for outgoing messages are set in create.
From Chromium. If an abrubt close happens while we're in the middle of writing data, don't invalidate the session.
Client auth now participates in signature algorithms. Test-wise, this was already covered by test 14, but since both sides implemented it wrong the test passed. Add a test at TLS 1.1 so coverage of the hash-less codepath isn't lost. From Chromium.
Enabling any faults just no-ops the handshake right now, so those tests so they were meaningless. The tests with the assert() lines were passing only because a bare expect will catch everything, including AssertionError.
tomato42
force-pushed
the
chromium-patches-2-fixed-up
branch
from
1b74c85
to
d0de9f8
Compare
Adapted and then rewritten from part of a Chromium patch. Adds a test which uses a Fault which disables this check on either peer.
tomato42
force-pushed
the
chromium-patches-2-fixed-up
branch
from
d0de9f8
to
77af4f5
Compare
|
obsoleted by #15 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reworked patches from trevp/tlslite pull request 98