SRP fixes #131
Merged
SRP fixes #131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the example uses incorrect syntax for SRP ciphersuites, use the current one
make the internal interfaces use bytearrays to pass usernames and passwords around, retain public API that accepts str add test cases so that file-based database continues to work fix verifierdb to work in python3 with files
|
tested, works! |
|
@The-Mule r? |
|
Reviewed 1 of 1 files at r1, 9 of 9 files at r2. Comments from Reviewable |
|
Looks good, r+ |
|
Thanks for the review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
update SRP command examples
make the commands work with both python2 and python3
should fix #130
This change is