DHE_RSA and AES-GCM #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adapted from a Chromium patch. This matches the other messages; __init__ gets passed parameters necessary to determine the behavior of parse (version, cipherSuite), while the fields for outgoing messages are set in create.
From Chromium. If an abrubt close happens while we're in the middle of writing data, don't invalidate the session.
Client auth now participates in signature algorithms. Test-wise, this was already covered by test 14, but since both sides implemented it wrong the test passed. Add a test at TLS 1.1 so coverage of the hash-less codepath isn't lost. From Chromium.
tomato42
force-pushed
the
chromium-patches-3-fixed-up
branch
from
bc4ab52
to
d5a55e5
Compare
|
|
Since we're checking on server side, we need to check for client certificate, not our (server) certificate
Enabling any faults just no-ops the handshake right now, so those tests so they were meaningless. The tests with the assert() lines were passing only because a bare expect will catch everything, including AssertionError.
Adapted and then rewritten from part of a Chromium patch. Adds a test which uses a Fault which disables this check on either peer.
Since it's safer to include what we know than the other way round, change the filter to output only ciphers we know includes test coverage for the method
From Chromium.
From Chromium.
no logic changes, just make the methods static
tomato42
force-pushed
the
chromium-patches-3-fixed-up
branch
from
d5a55e5
to
7614023
Compare
|
|
provide documentation, don't redefine builtins, use consistent naming scheme
|
|
tomato42
added a commit
that referenced
this pull request
Jun 20, 2015
DHE_RSA and AES-GCM from Chromium
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementation of DHE_RSA and AES-GCM with assorted fixes.
This change is