TLS 1.3 padding support #217
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomato42
requested changes
Feb 22, 2018
| @@ -185,6 +189,7 @@ def __init__(self): | |||
| self.dhParams = None | |||
| self.dhGroups = list(ALL_DH_GROUP_NAMES) | |||
| self.defaultCurve = "secp256r1" | |||
| self.padding_cb = None | |||
There was a problem hiding this comment.
needs to be copied in validate()
tlslite/recordlayer.py
Outdated
| data += bytearray([contentType]) | ||
| if self.padding_cb: | ||
| # add number of zero bytes specified by padding_cb() | ||
| data += bytearray(self.padding_cb(len(data), contentType)) |
There was a problem hiding this comment.
callback should get the maximum size of padding it can add as one of the parameters
|
so the max size should be the |
ep69
force-pushed
the
tls-1.3-padding
branch
from
5f8e4a6
to
5deb128
Compare
tomato42
approved these changes
Feb 23, 2018
|
looks good, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #189
This change is