deprecate non-pythonic names #218
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomato42
force-pushed
the
pythonic_names
branch
3 times, most recently
from
f1d7be8
to
03cba55
Compare
tomato42
changed the title
a lot of methods use parameters names that use camelCase, which is unpythonic, add a decorator that will allow renaming them without breaking backwards compatibility
use the new pylint generated pylintrc as a guide, update rgx
tomato42
force-pushed
the
pythonic_names
branch
from
56e5ccc
to
1e4c092
Compare
|
@t8m thank you! |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
old code used camelCase for attributes and method names, that's unpythonic
add decorators that allow us to retain API while changing names of those identifiers
This change is