fix FFDHE key exchange in TLS 1.3 #274
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
10 tasks
Jakuje
reviewed
Jun 19, 2018
in TLS 1.3 the FFDH key share must be the size of the prime (it must be left-padded with zeros), while it could have been padded or had the zero bytes truncated in TLS 1.2 and earlier that means it needs to be passed as a bytearray to key exchange handling methods while it was passed as an integer previously make the function handle both inputs and verify the size of the share in case of TLS 1.3-like call
|
@Jakuje commit message updated |
Jakuje
approved these changes
Jun 19, 2018
|
@Jakuje thanks for the review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
in TLS 1.3 the FFDH key share must be the size of the
prime while it could have been padded or had the zero
bytes truncated in TLS 1.2 and earlier
that means it needs to be passed as a bytearray to key
exchange handling methods while the it was passed as an
integer previously
make the funcion handle both inputs and verify the size
of the share in case of TLS 1.3-like call
This change is