Test coverage for cryptomath #281
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomato42
added
the
maintenance
Jakuje
reviewed
Jun 28, 2018
| @@ -194,6 +194,16 @@ def test_numBits(self, number): | |||
| def test_numBytes(self, number): | |||
| self.assertEqual(numBytes(number), self.num_bytes(number)) | |||
|
|
|||
|
|
|||
| class TestPowMod(unittest.TestCase): | |||
| def test_with_small_numerts(self): | |||
There was a problem hiding this comment.
The numerts looks like a typo.
tlslite/utils/cryptomath.py
Outdated
| @@ -253,8 +253,7 @@ def numBytes(n): | |||
| # ************************************************************************** | |||
|
|
|||
| def getRandomNumber(low, high): | |||
| if low >= high: | |||
| raise AssertionError() | |||
| assert low <= high | |||
There was a problem hiding this comment.
This should say low < high to preserve the same semantics. Does it make sense to generate random, where low == high? If so, the change in semantics should be reflected in the commit message.
don't rise the assert directly, makes the exception more readable and code coverage happy
the negative power is not used anywhere in the code and gmpy does not actually support it either so remove this code
tomato42
force-pushed
the
test_cov_for_cryptomath
branch
from
4123c3c
to
eb5c1fa
Compare
|
@Jakuje thanks for the review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Increase test coverage for cryptomath.py module, remove dead code
This change is