Bit of maintenance in the extensions module #282
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
there was quite a bit of duplication in the code, and many return statements, fix it
fix indentation levels, remove unnecessary "\" between brackets, make block comments start with "# ", insert double newline before class definitions
tomato42
added
the
maintenance
|
Reviewed 1 of 1 files at r2. Comments from Reviewable |
complete! all files reviewed, all discussions resolved (waiting on 
ep69
approved these changes
Jul 2, 2018
tomato42
force-pushed
the
simplify_extension
branch
from
23a469d
to
5a33fa6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix few style issues in the extensions module, simplify code
This change is