Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pure-python 3des bytearray #292

Merged
merged 1 commit into from
Jul 18, 2018
Merged

pure-python 3des bytearray #292

merged 1 commit into from
Jul 18, 2018

Conversation

tomato42
Copy link
Member

@tomato42 tomato42 commented Jul 16, 2018

make the pure 3des python implementation behave the same way the other 3des implementations do


This change is Reviewable

@tomato42 tomato42 added the bug unintented behaviour in tlslite-ng code label Jul 16, 2018
@tomato42 tomato42 added this to the v0.8.0 milestone Jul 16, 2018
@tomato42 tomato42 self-assigned this Jul 16, 2018
as m2crypto and pycrypto 3des wrappers return bytearrays()
change the pure-python implementation to do the same
Copy link
Collaborator

@ep69 ep69 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 2 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@ep69 ep69 merged commit 21b0b4b into master Jul 18, 2018
@tomato42 tomato42 deleted the 3des-bytearray branch July 18, 2018 18:24
@tomato42
Copy link
Member Author

thanks for review!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug unintented behaviour in tlslite-ng code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants