Fix tests of key type used for verification #337
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
as rsa-pss keys can't be used to verify pkcs#1 signatures, we need to keep track what type of key we have
decryption_failed is a legacy alert for when the padding didn't match for symmetric encryption, decrypt_error needs to be used when the signature is malformed - but since we know what algorithms are valid for the certificate provided by client, and they don't match, send illegal_parameter this also introduces consistent behaviour between TLS 1.3 and earlier protocols
7 tasks
tomato42
force-pushed
the
key-type-for-verification
branch
from
4c559e4
to
e70a2af
Compare
|
Working on review. |
The-Mule
approved these changes
Jan 15, 2019
There was a problem hiding this comment.
r+
Reviewed 2 of 6 files at r6, 5 of 5 files at r8.
Reviewable status:complete! all files reviewed, all discussions resolved
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
make server use client provided certificate to check if it selected correct signature algorithm, abort if it didn't
also minor clean ups of related modules
fixes #279
This change is