Fix TLS1.3 handshakes to refuse pkcs1 signatures #339
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
10 tasks
We were not passing the protocol version to _sigHashesToList so the fucntion was not stripping pkcs1 signature schemes and allowing them. Signed-off-by: Simo Sorce <simo@redhat.com>
simo5
force-pushed
the
tls13fixvalidsigalg
branch
from
795b917
to
75507e8
Compare
tomato42
approved these changes
Jan 17, 2019
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @simo5)
|
Nice catch, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were not passing the protocol version to _sigHashesToList so
the fucntion was not stripping pkcs1 signature schemes and allowing
them.
This change is