Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Misctls13fixes #340

Merged
merged 2 commits into from
Jan 17, 2019
Merged

Misctls13fixes #340

merged 2 commits into from
Jan 17, 2019

Conversation

simo5
Copy link
Collaborator

@simo5 simo5 commented Jan 17, 2019

Misc fixes to minor bugs uncovered while working on tlsfuzzer/tlsfuzzer#496


This change is Reviewable

Copy link
Member

@tomato42 tomato42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r1, 1 of 1 files at r2.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

Copy link
Member

@tomato42 tomato42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @simo5)


tlslite/keyexchange.py, line 233 at r1 (raw file):

                # handles negative test cases when we try to pass in
                # schemes that are not supported in TLS1.3
                hash_name = HashAlgorithm.toRepr(signatureAlg[0])

if it's behaviour that other code depends on, then we need a unit test to verify that it works

This is used by tlsfuzzer when testing sending signatures using
algorithms that should not be accepted by TLS1.3 implementations.

Signed-off-by: Simo Sorce <simo@redhat.com>
We were just closing the connection instead of sending the proper alert
message to the client first.

Signed-off-by: Simo Sorce <simo@redhat.com>
Copy link
Member

@tomato42 tomato42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 2 files at r3, 1 of 1 files at r4.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @simo5)

Copy link
Member

@tomato42 tomato42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, looks good, feel free to merge when CI passes

Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@simo5 simo5 merged commit e735f23 into tlsfuzzer:master Jan 17, 2019
@tomato42 tomato42 added the bug unintented behaviour in tlslite-ng code label Jan 25, 2019
@tomato42 tomato42 added this to To do in TLS 1.3 support via automation Jan 25, 2019
@tomato42 tomato42 added this to the v0.8.0 milestone Jan 25, 2019
@tomato42 tomato42 moved this from To do to Done in TLS 1.3 support Jan 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug unintented behaviour in tlslite-ng code
Projects
Development

Successfully merging this pull request may close these issues.

None yet

2 participants