-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Misctls13fixes #340
Misctls13fixes #340
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r1, 1 of 1 files at r2.
Reviewable status: complete! all files reviewed, all discussions resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @simo5)
tlslite/keyexchange.py, line 233 at r1 (raw file):
# handles negative test cases when we try to pass in # schemes that are not supported in TLS1.3 hash_name = HashAlgorithm.toRepr(signatureAlg[0])
if it's behaviour that other code depends on, then we need a unit test to verify that it works
This is used by tlsfuzzer when testing sending signatures using algorithms that should not be accepted by TLS1.3 implementations. Signed-off-by: Simo Sorce <simo@redhat.com>
We were just closing the connection instead of sending the proper alert message to the client first. Signed-off-by: Simo Sorce <simo@redhat.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 2 of 2 files at r3, 1 of 1 files at r4.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @simo5)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok, looks good, feel free to merge when CI passes
Reviewable status: complete! all files reviewed, all discussions resolved
Misc fixes to minor bugs uncovered while working on tlsfuzzer/tlsfuzzer#496
This change is