Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

allow setting 0 tickets to disable sending tickets in TLS 1.3 #347

Merged
merged 1 commit into from
Apr 1, 2019
Merged

allow setting 0 tickets to disable sending tickets in TLS 1.3 #347

merged 1 commit into from
Apr 1, 2019

Conversation

tomato42
Copy link
Member

@tomato42 tomato42 commented Mar 27, 2019 •
edited
Loading

This change is Reviewable

@tomato42 tomato42 added the enhancement new feature to be implemented label Mar 27, 2019
@tomato42 tomato42 added this to the v0.8.0 milestone Mar 27, 2019
@tomato42 tomato42 self-assigned this Mar 27, 2019
@tomato42 tomato42 requested a review from The-Mule April 1, 2019 14:58
The-Mule
The-Mule approved these changes Apr 1, 2019
View reviewed changes
Copy link
Collaborator

@The-Mule The-Mule left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r+

All changes look good to me and test coverage for the changes covers all cases (negative, zero and positive tickets count).

@tomato42 tomato42 merged commit 849f1d1 into master Apr 1, 2019
@tomato42 tomato42 deleted the zero-tickets branch April 1, 2019 15:03
@tomato42
Copy link
Member Author

tomato42 commented Apr 1, 2019

Thanks for review!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@The-Mule The-Mule The-Mule approved these changes

Assignees

@tomato42 tomato42

Labels
enhancement new feature to be implemented
Projects
None yet
Milestone
v0.8.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@tomato42 @The-Mule