Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TLS 1.3 ECDH and key_shares fixes #388

Merged
merged 3 commits into from
Jan 10, 2020
Merged

TLS 1.3 ECDH and key_shares fixes #388

merged 3 commits into from
Jan 10, 2020

Conversation

tomato42
Copy link
Member

@tomato42 tomato42 commented Jan 9, 2020 •
edited
Loading

fix handling malformed ECDH key shares and malformed key_shares extension

don't create malformed ones ourselves

fixes bugs identified by tlsfuzzer/tlsfuzzer#553

This change is Reviewable

@tomato42 tomato42 added the bug unintented behaviour in tlslite-ng code label Jan 9, 2020
@tomato42 tomato42 added this to the v0.8.0 milestone Jan 9, 2020
@tomato42 tomato42 self-assigned this Jan 9, 2020
@tomato42 tomato42 added this to To do in TLS 1.3 support via automation Jan 9, 2020
@tomato42 tomato42 mentioned this pull request Jan 9, 2020
Merged
10 tasks
@tomato42 tomato42 requested a review from simo5 January 10, 2020 14:34
@simo5
Copy link
Collaborator

simo5 commented Jan 10, 2020

LGTM,
all three commits are clear and look obvious and right

simo5
simo5 approved these changes Jan 10, 2020
View reviewed changes
Copy link
Collaborator

@simo5 simo5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

@simo5 simo5 merged commit 8dfbf3e into master Jan 10, 2020
TLS 1.3 support automation moved this from To do to Done Jan 10, 2020
@tomato42 tomato42 deleted the tls13-ecdh-fixes branch January 13, 2020 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simo5 simo5 simo5 approved these changes

Assignees

@tomato42 tomato42

Labels
bug unintented behaviour in tlslite-ng code
Projects
TLS 1.3 support
  
Done
Milestone
v0.8.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@tomato42 @simo5