-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update test vector to released RFC version #397
Conversation
@tomato42 3.6 failed in travis. Searching around for the error it looks like the issue is in pluggy, have you seen this issue before? |
It may be this one: pytest-dev/pytest#3753 try adding explicit dependency to build-requires.txt |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r1.
Reviewable status: all files reviewed, 5 unresolved discussions (waiting on @inikolcev)
unit_tests/test_tls1_3_vectors.py, line 317 at r1 (raw file):
""")) # calculate finished "tls13 finished"
"derive key for Finished message" or "derive key for calculation of verify_data of Finished`
unit_tests/test_tls1_3_vectors.py, line 343 at r1 (raw file):
server_finished_payload = server_finished_message.write() # prepare the handshake transcript for the next secrets
"... for the client secrets"
unit_tests/test_tls1_3_vectors.py, line 346 at r1 (raw file):
handshake_hashes.update(server_finished_payload) # derive secret "tls13 c ap traffic"
derive keys for client application traffic
unit_tests/test_tls1_3_vectors.py, line 355 at r1 (raw file):
""")) # derive secret "tls13 s ap traffic"
derive keys for server application traffic
unit_tests/test_tls1_3_vectors.py, line 364 at r1 (raw file):
""")) # derive secret "exp master"
derive exporter master secret
80a1378
to
48bea3a
Compare
48bea3a
to
a5a6d99
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 2 of 2 files at r2, 1 of 1 files at r3.
Reviewable status:complete! all files reviewed, all discussions resolved
looks good, thanks! |
Fixes #308
This change is![Reviewable](https://camo.githubusercontent.com/23b05f5fb48215c989e92cc44cf6512512d083132bd3daf689867c8d9d386888/68747470733a2f2f72657669657761626c652e696f2f7265766965775f627574746f6e2e737667)