Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update test vector to released RFC version #397

Merged
merged 2 commits into from
Mar 24, 2020

Conversation

inikolcev
Copy link
Collaborator

@inikolcev inikolcev commented Mar 23, 2020

Fixes #308


This change is Reviewable

@inikolcev inikolcev requested a review from tomato42 March 23, 2020 11:18
@inikolcev
Copy link
Collaborator Author

@tomato42 3.6 failed in travis. Searching around for the error it looks like the issue is in pluggy, have you seen this issue before?

@tomato42
Copy link
Member

It may be this one: pytest-dev/pytest#3753 try adding explicit dependency to build-requires.txt

Copy link
Member

@tomato42 tomato42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r1.
Reviewable status: all files reviewed, 5 unresolved discussions (waiting on @inikolcev)


unit_tests/test_tls1_3_vectors.py, line 317 at r1 (raw file):

                         """))

        # calculate finished "tls13 finished"

"derive key for Finished message" or "derive key for calculation of verify_data of Finished`


unit_tests/test_tls1_3_vectors.py, line 343 at r1 (raw file):

        server_finished_payload = server_finished_message.write()

        # prepare the handshake transcript for the next secrets

"... for the client secrets"


unit_tests/test_tls1_3_vectors.py, line 346 at r1 (raw file):

        handshake_hashes.update(server_finished_payload)

        # derive secret "tls13 c ap traffic"

derive keys for client application traffic


unit_tests/test_tls1_3_vectors.py, line 355 at r1 (raw file):

                         """))

        # derive secret "tls13 s ap traffic"

derive keys for server application traffic


unit_tests/test_tls1_3_vectors.py, line 364 at r1 (raw file):

                         """))

        # derive secret "exp master"

derive exporter master secret

@inikolcev inikolcev force-pushed the update_tls1_3_vectors branch 6 times, most recently from 80a1378 to 48bea3a Compare March 23, 2020 16:53
Copy link
Member

@tomato42 tomato42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 2 files at r2, 1 of 1 files at r3.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@tomato42 tomato42 merged commit c32629e into tlsfuzzer:master Mar 24, 2020
@tomato42
Copy link
Member

looks good, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update the TLS 1.3 vectors to released version
2 participants