Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(deprecations.py): fix for cases result is None #424

Closed
wants to merge 1 commit into from
Closed

fix(deprecations.py): fix for cases result is None #424

wants to merge 1 commit into from

Conversation

jossef
Copy link

@jossef jossef commented Oct 5, 2020

closes #423


This change is Reviewable

@tomato42
Copy link
Member

tomato42 commented Oct 8, 2020

I'm not entirely convinced that this is a bug in tlslite-ng code... Looking at inspect documentation, it doesn't mention that the returned context can be empty.

Could you check first with pyinstaller developers, so that it's not a bug in their code that we're just patching over?

@tomato42
Copy link
Member

tomato42 commented Nov 3, 2020

@jossef did you rise it as an issue with pyinstaller developers?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

when packed with pyinstaller deprecations.py raises an error
2 participants