[v5] Small TLSRecordLayer refactor #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add generic TLS message class
extend exceptions hierarchy to allow for internal handling of errors
|
|
initializers can be shared between RecordHeader2 and RecordHeader3 also add some documentation to the classes
fixes pylint W0631 undefined-loop-variable. this is not entirely necessary, as _recvHeader() and _sockRecvAll() will never return without yielding at least once
|
|
|
|
tomato42
added a commit
that referenced
this pull request
Jun 2, 2015
[v5] Small TLSRecordLayer refactor Prepare TLSRecordLayer for moving encryption and decryption to external class. unit test coverage for sending and receiving records through socket, minimal test coverage for TLSRecordLayer (using private methods).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prepare
TLSRecordLayerfor moving encryption and decryption to external class.unit test coverage for sending and receiving records through socket, minimal test coverage for TLSRecordLayer (using private methods).