[v3] Record layer refactor #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add generic TLS message class
extend exceptions hierarchy to allow for internal handling of errors
initializers can be shared between RecordHeader2 and RecordHeader3 also add some documentation to the classes
fixes pylint W0631 undefined-loop-variable. this is not entirely necessary, as _recvHeader() and _sockRecvAll() will never return without yielding at least once
add RecordLayer class and assorted classes to implement sending encrypted messages using TLS record layer protocol
This was of relevance only to SSLv3 - TLSv1.0 and later include on-the-wire protocol version in the MAC input, so if the content is MACed the version check is performed implicitly
stop TLSRecordLayer using private fields of RecordLayer
class was moved to recordlayer module
fixes pylint C0103 (invalid-name)
fixes pylint C0103 (invalid-name)
resolves pylint C0103 (invalid-name)
since the code is essentially the same, we can move it to a separate method
W0631 undefined-loop-variable - not necessary as recv() will always yield at least once before returning
|
|
remove unused imports, fix documentation warnings, add excuses for not fixing other issues
|
|
1 similar comment
tomato42
added a commit
that referenced
this pull request
Jun 2, 2015
Closes #7 Conflicts: tlslite/errors.py tlslite/messages.py tlslite/recordlayer.py tlslite/tlsrecordlayer.py unit_tests/mocksock.py unit_tests/test_tlslite_recordlayer.py
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move record encryption and decryption to separate class, put it under full unit test coverage.
Rebased on top of current master, together with changes from pull #5 (commits since 9fc246c are the real addition).