Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error in analysis due to pandas bug #30

Closed
ghost opened this issue Jun 8, 2019 · 3 comments
Closed

Error in analysis due to pandas bug #30

ghost opened this issue Jun 8, 2019 · 3 comments

Comments

@ghost
Copy link

ghost commented Jun 8, 2019

@TomAugspurger, I found pandas-dev/pandas#22509 by chasing down an error in part 2. You use the broken form of groupby().transform('rank') in "Chaining methods", to create this graph:

flights

If you use dep_time.rank() instead you get the correct result

flights

@ghost ghost changed the title Error in Part 2 flights analysis example/graph due to a long-standing pandas bug Error in analysis due to pandas bug Jun 12, 2019
@ghost
Copy link
Author

ghost commented Jun 13, 2019

See pandas-dev/pandas#22509 (comment) for comparison of rank() and currently broken transform('rank').

@ghost
Copy link
Author

ghost commented Jun 13, 2019

ping @TomAugspurger, have you seen this yet? you're so responsive on pandas, but this has been here for a few days, just wondering.

@TomAugspurger
Copy link
Owner

TomAugspurger commented Jun 13, 2019 via email

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant