Add eol to letsencrypt provided files [Issue #110]

[willtho89]

Some LE tools like simp_le create the cert files with no end-of-line. This change adds an eol if non exists.

If a file does not exist, sed throws an error on STDERR. It might be a good idea to check for file existence first like in the "self-signed" and "custom" case.

This fixes Issue #110 .

[tomav]

Thank you @reldeiS

[00angus]

I've just discovered that this patch unlink the files in the 'live' directory of LE config dir, in particular:

• under the 'live' path there are symlinks to the archive directory, for continuity between updates
• the patch sed -i -e '$a\' /etc/letsencrypt/live/$(hostname)/cert.pem cause the unlink in the 'live' directory and the creation of a new file not linked to the one in the archive directory

@reldeiS : does this may breaks future updates of letsencrypt certificates ?

[willtho89]

I can't recreate this on my machine in a quick test. The files created with the standard LE binary already have the eol, so the files are not changed.
I'll look into it.

@tomav I will change it the way Dominik suggested in #110. That way the LE created files are never touched and no unlinking should happen

[00angus]

Thanks for the fast update. Anyway for future reference the problem arise even in case EOLs are presents in the files, the problem being simply the use of the switch '-i' to sed itself.

[willtho89]

yes i see where the problem was. On my host (Ubuntu 14.04) the links stay in tact.
However i fixed it in #118 by simply not changing the LE created *.pem files