Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix shebangs #1737

Merged
merged 1 commit into from Jan 2, 2021
Merged

Fix shebangs #1737

merged 1 commit into from Jan 2, 2021

Conversation

williamdes
Copy link
Member

@williamdes williamdes commented Jan 2, 2021

  • Fixes shebangs

@georglauterbach
Copy link
Member

I do not see how this fixes anything - don't get me wrong, I do not want to impolite, but the choices of shebangs and readme fences were on purpose. I think they are fine they way they are.

@williamdes
Copy link
Member Author

Okay, but for me the readme fences are incorrect

Please let me know why some script use a space and some do not so I can revert that :)

@georglauterbach
Copy link
Member

This project uses all-uppercase readme fences with a space between the three hyphens. There are still some inconsistencies - feel free to resolve them. The scripts should all use #! /SOME/PATH, i.e. with a space after #!. If there are inconsistencies too, I'd be happy to see them resolved too.

@williamdes
Copy link
Member Author

This project uses all-uppercase readme fences with a space between the three hyphens.

But why and where does it come from, it just feels strange to me

Okay I will revert and fix the non spaced files

@georglauterbach
Copy link
Member

This project uses all-uppercase readme fences with a space between the three hyphens.

But why and where does it come from, it just feels strange to me

Okay I will revert and fix the non spaced files

I guess personal preference. To me, it feels strange to do it in another way. I just feel like this is clean and I would not really like to change whats stable there:) I'd like the readme fences to stay as they are.

@williamdes williamdes changed the title Fix shebangs and readme fences Fix shebangs Jan 2, 2021
@georglauterbach georglauterbach merged commit 66422cb into docker-mailserver:master Jan 2, 2021
@williamdes williamdes deleted the fix/bangs branch January 2, 2021 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants