Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Panning and zooming needs improvement #16

Closed
tomayac opened this issue Oct 20, 2021 · 5 comments
Closed

Panning and zooming needs improvement #16

tomayac opened this issue Oct 20, 2021 · 5 comments
Labels
bug Something isn't working

Comments

@tomayac
Copy link
Owner

tomayac commented Oct 20, 2021

Better on desktop, but still not feels 100% natural. It's worse on mobile.

@tomayac
Copy link
Owner Author

tomayac commented Oct 20, 2021

@tomayac tomayac added the bug Something isn't working label Oct 20, 2021
@argyleink
Copy link
Collaborator

I had some odd snapping happening, where i'd hover and it'd snap to a different zoom level. trying to find sequential repro steps.

@dwelle
Copy link

dwelle commented Nov 20, 2021

The biggest problem I see is that panning doesn't account for zoom. On high zoom, slight panning moves the canvas too much. When zoomed out, panning barely moves the canvas.

Another bug: once you pan, you can zoom in/out beyond the limit. Repro: 1) zoom out to 0.1 2) pan canvas a bit 3) you are allowed to zoom out again 4) repeat ad infinitum.

@Fuzzyma
Copy link

Fuzzyma commented Nov 21, 2021

Maybe it helps to see how https://github.com/svgdotjs/svg.panzoom.js does it. I am the Maintainer and afaik it works pretty good

@tomayac
Copy link
Owner Author

tomayac commented Jan 5, 2022

I have now moved to pinch-zoom, which introduced a drifting bug on pinch-zooming, tracked in #46. It's definitely still better than what we had before. Hoping for an eventual fix here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants