Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Leaflet sub-directives should be prefixed #332

Closed
pgayvallet opened this issue Mar 19, 2014 · 3 comments
Closed

Leaflet sub-directives should be prefixed #332

pgayvallet opened this issue Mar 19, 2014 · 3 comments

Comments

@pgayvallet
Copy link

leaflet subdirective should be prefixed to avoid directive collision with other libs. Most dangerous directive is the 'legend' directive which require "^leaflet". Common directive names should be prefixed ( aka leafletLegend, lfLegend or any prefix ).

@tombatossals
Copy link
Owner

You're totally right, I read an article about this after the directive was already released. :( Now it would break compatibility, but it would be not much problematic to solve.

Maybe we can think about prefixing the directives on a future release.

Thanks for sharing!

@nmccready
Copy link
Contributor

This issue was moved to angular-ui/ui-leaflet#12

@nmccready nmccready reopened this Oct 29, 2015
@tombatossals
Copy link
Owner

I'm going to rework&redesign angular-leaflet-directive to be compatible with Leaflet v1.0. It will mantain almost all its functionality, and will be compatible with the current features of the directive, but I must start from a fresh point, so I'm going to close this issue. If you think it must be worked with the new version, please reopen it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants