Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Import Errors in Swift #355

Open
AnthonyMDev opened this issue Jun 28, 2016 · 4 comments
Open

Import Errors in Swift #355

AnthonyMDev opened this issue Jun 28, 2016 · 4 comments

Comments

@AnthonyMDev
Copy link

I'm getting an error when importing this library in Swift `'NUIParse.h' file not found.

This is fixed by changing all import statements from #import "NUIParse.h" to #import <NUIParse/NUIParse.h>.

Does this change break anything for Objective-C users?

@Stunner
Copy link
Collaborator

Stunner commented Jun 28, 2016

No, it shouldn't cause any problem for Objective-C users. If you could submit a pull request with these changes I'd be happy to merge it in.

@AnthonyMDev
Copy link
Author

Handling that now 👍

@AnthonyMDev
Copy link
Author

AnthonyMDev commented Jun 28, 2016

It looks like this is actually fixed on master using:

#if __has_include(<NUIParse/NUIParse.h>)
#    import <NUIParse/NUIParse.h>
#else
#    import "NUIParse.h"
#endif

@Stunner I know you have a few more work packages for the release of 0.6.0but is there anyway we can get a new patch version for 0.5 pushed with this change? Because the current version is unusable with swift targets.

@AnthonyMDev AnthonyMDev reopened this Jun 28, 2016
@Stunner
Copy link
Collaborator

Stunner commented Jun 29, 2016

@timbodeit Your thoughts on this? Considering we are both awfully inactive on this project these days, it may make sense to roll out a 0.5.x release to tie people over until we can get 0.6.0 ready and working.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants