Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changing only the CHANGELOG.md file doesn't trigger the MessageSkipBuildTag rule #48

Closed
tombruijn opened this issue Aug 6, 2022 · 1 comment
Labels
bug Something isn't working

Comments

@tombruijn
Copy link
Member

Not sure what happens here:

$ lintje --version
lintje 0.8.0

$ lintje 
[DEBUG] No issues found for commit '8c166d5c75dcc74ed2d93d97d467b16ee53dac3f' in rule 'MessageSkipBuildTag'
[DEBUG] Commits: [Commit { long_sha: Some("8c166d5c75dcc74ed2d93d97d467b16ee53dac3f"), short_sha: Some("8c166d5"), email: Some("tom@tomdebruijn.com"), subject: "URL detection ticket references is a addition", message: "\nIn the CHANGELOG mark the URL detection and better detection for the\nrepo shorthands as a new feature rather than a change. It does more now.\n", file_changes: ["CHANGELOG.md"], issues: [Issue { type: Hint, rule: MessageTicketNumber, message: "The message body does not contain a ticket or issue number", position: MessageLine { line: 6, column: 1 }, context: [Context { type: Plain, line: Some(4), content: "repo shorthands as a new feature rather than a change. It does more now.", range: None, message: None }, Context { type: Plain, line: Some(5), content: "", range: None, message: None }, Context { type: Addition, line: Some(6), content: "Fixes #123", range: Some(0..10), message: Some("Consider adding a reference to a ticket or issue") }] }], ignored: false, ignored_rules: [] }]
@tombruijn tombruijn added the bug Something isn't working label Aug 6, 2022
@tombruijn
Copy link
Member Author

I forgot I didn't configure this for CHANGELOG.md because some builds may check is the file is valid or not.

@tombruijn tombruijn closed this as not planned Won't fix, can't repro, duplicate, stale Aug 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant