Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

warning about unknown props #63

Closed
beckend opened this issue Jul 3, 2016 · 5 comments
Closed

warning about unknown props #63

beckend opened this issue Jul 3, 2016 · 5 comments

Comments

@beckend
Copy link

beckend commented Jul 3, 2016

By just mounting the container on react 15.2.0:

Warning: Unknown props `toastMessageFactory`, `toastType`, `preventDuplicates`, `newestOnTop` on <div> tag. Remove these props from the element. For details, see https://fb.me/react-unknown-prop
    in div (created by ToastContainer)
    in ToastContainer (created by Toastr)
    in Toastr (created by App)
@mikecousins
Copy link

Yeah, the React team says this needs to be fixed as it will break in the next version: facebook/react#7152 (comment)

@RangarajKaushikSundar
Copy link
Collaborator

Seems like there is a bit of refactoring in place. Good share @beckend @mikecousins !

@ghost
Copy link

ghost commented Jul 15, 2016

Did anyone find the cause and a subsequent fix for this?

@RangarajKaushikSundar
Copy link
Collaborator

@Harryandrew The component will work on lower versions of React. I have included this component in my project and am using React v15.1.0. I don't seem to face this issue, the code would need refactoring to circumvent this problem.

@tomchentw
Copy link
Owner

Released v2.8.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants