Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use default reason phrases from HTTP standard. #2764

Merged
merged 1 commit into from Mar 25, 2015
Merged

Use default reason phrases from HTTP standard. #2764

merged 1 commit into from Mar 25, 2015

Conversation

jpadilla
Copy link
Member

Ticket: https://code.djangoproject.com/ticket/24137
Pull Request: django/django#3902

django.core.handlers.wsgi.STATUS_CODE_TEXT has been removed in favor of using Python's stdlib instead, http.client.responses for Python 3 and httplib.responses for Python 2.

@carltongibson
Copy link
Collaborator

Fixes #2763.

This looks good.

Why Travis no run?

@jpadilla
Copy link
Member Author

@carltongibson I was wondering that same thing. It's not even under pull requests.

@carltongibson
Copy link
Collaborator

@jpadilla Nice link. Not the one you meant though. :-)

@jpadilla
Copy link
Member Author

@carltongibson ugh fixed, at least it wasn't something embarrassing.

@carltongibson
Copy link
Collaborator

Indeed. :-)

My Travis-Foo isn't up to knowing how to shout at it.

@carltongibson
Copy link
Collaborator

This SO answer says close the PR and re-open to trigger the build. Slightly heavy handed but I guess it'd work. (The web hook must have fizzled I guess.)

@jpadilla jpadilla closed this Mar 25, 2015
@jpadilla jpadilla reopened this Mar 25, 2015
@jpadilla
Copy link
Member Author

@carltongibson yeap that worked, thanks.

@carltongibson
Copy link
Collaborator

Well let's have this one then. Thanks @jpadilla!

carltongibson pushed a commit that referenced this pull request Mar 25, 2015
Use default reason phrases from HTTP standard. Fixes #2763
@carltongibson carltongibson merged commit aa131ae into encode:master Mar 25, 2015
@jpadilla jpadilla added this to the 3.1.2 Release milestone Mar 25, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants