Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for coveralls. #3107

Closed
wants to merge 3 commits into from
Closed

Conversation

xordoquy
Copy link
Collaborator

@xordoquy xordoquy commented Jul 2, 2015

Not sure it'll work out of the box, let's see with a PR.

@xordoquy
Copy link
Collaborator Author

xordoquy commented Jul 2, 2015

Note that this PR is linked with #2936

@jpadilla
Copy link
Member

jpadilla commented Jul 2, 2015

@xordoquy there's also pytest-cov

@xordoquy
Copy link
Collaborator Author

xordoquy commented Jul 2, 2015

@jpadilla right, but I need to update first runtest.
I wonder why we don't go straight with py.test command line nowadays

@xordoquy
Copy link
Collaborator Author

xordoquy commented Jul 2, 2015

@thedrow
Copy link
Contributor

thedrow commented Jul 3, 2015

Just FYI there's also http://codecov.io which has a bit more features like failing the build when coverage decreases.
Doesn't matter much though.

@tomchristie
Copy link
Member

@thedrow Looks nice. Thanks for noting that.

@xordoquy
Copy link
Collaborator Author

xordoquy commented Jul 3, 2015

@tomchristie I'd like your feeling on f19c145

@tomchristie
Copy link
Member

I'd like your feeling on f19c145

@xordoquy I think ideally my preference in all of this would be to treat #2936 as a pre-requisite to any coverage service integration. It'd be nicer if our travis builds did something that's as close as possible to how we run tests locally. (IE yeah using runtests is preferable, really)

@tomchristie
Copy link
Member

Let's stay with #2936 being a pre-requisite for integrating any coverage service.
I'd rather see us add this in in an agnostic way first, and then make an informed choice on which, if any, service we should integrate that with.

@xordoquy xordoquy deleted the feature/coveralls branch December 7, 2015 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants