Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

convert some more test asserts to pytest #4778

Merged
merged 3 commits into from Jan 4, 2017
Merged

convert some more test asserts to pytest #4778

merged 3 commits into from Jan 4, 2017

Conversation

auvipy
Copy link
Member

@auvipy auvipy commented Jan 4, 2017

more clean ups

@xordoquy
Copy link
Collaborator

xordoquy commented Jan 4, 2017

looks good to me, waiting travis to finish the tests.

tomchristie
tomchristie requested changes Jan 4, 2017
View reviewed changes
Copy link
Member

@tomchristie tomchristie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup good stuff! Couple of linter failures which need resolving.

tests/test_utils.py
('Nested Resource Root', '/resource/123/'),
('Nested Resource Instance', '/resource/123/abc')
]

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Drop the extra newline here.

tests/test_utils.py
[('Root', '/')]
)
assert get_breadcrumbs(url) == [('Root', '/')]

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Drop the extra newline here.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

auvipy
auvipy commented Jan 4, 2017
View reviewed changes
Copy link
Member Author

@auvipy auvipy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@tomchristie tomchristie merged commit 7874bca into encode:master Jan 4, 2017
@tomchristie
Copy link
Member

Thanks!

@auvipy auvipy deleted the pytst branch May 23, 2018 10:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomchristie tomchristie tomchristie approved these changes

Assignees
No one assigned
Labels
Cleanup
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@auvipy @xordoquy @tomchristie