tweaks to writable nested serializers #739
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -360,7 +360,9 @@ def field_from_native(self, data, files, field_name, into): | |||
| except KeyError: | |||
| if self.required: | |||
| raise ValidationError(self.error_messages['required']) | |||
| return | |||
| if self.default is None: | |||
There was a problem hiding this comment.
This should probably mirror the WritableField style:
if self.default is not None and not self.partial:
# Note: partial updates shouldn't set defaults
value = copy.deepcopy(self.default)
else:
if self.required:
raise ValidationError(self.error_messages['required'])
return
|
LGTM. I'll let @tomchristie handle merging it in if he wants. |
|
Also, have you done much testing with this branch? I'd be interested to get some feedback on real world usage. |
|
@maspwr We're not using the branch in production yet, just on my dev VM. It's going to be an export API for http://koordinates.com . Basically you can create a download of some spatial data by posting to the API. A typical post might look something like https://gist.github.com/craigds/15a5aeffe3e831018547 |
|
OK, cool. Looks like pretty typical usage. Let us know if you run into any issues. Thanks for the info! |
tomchristie
added a commit
that referenced
this pull request
Mar 18, 2013
tweaks to writable nested serializers
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
allows required and default kwargs in field constructor for serializers.