Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small but notable lag with enabled Radiation #807

Closed
Krutoy242 opened this issue Sep 28, 2023 · 2 comments
Closed

Small but notable lag with enabled Radiation #807

Krutoy242 opened this issue Sep 28, 2023 · 2 comments

Comments

@Krutoy242
Copy link

Overhauled, radiation_enabled=true.

I'm maintaining E2E-E server. I found that NC:O causing about 2% of TPS lag.

image

By looking through source code, i found that most heavy calls is loadedChunks.toArray and transferRadiationFromProviderToChunkBuffer.

  • How can I improve TPS on my server without completely disabling radiation? My radiation_world_chunks_per_tick set to 5, but seems like loadedChunks.toArray would constantly consume same amount of CPU, no matter of config.
  • How I could optimize transferRadiationFromProviderToChunkBuffer or make it not called at all? I cant find a config for disabling TEs to contribute chunk radiation.

Profile: spark.lucko.me/dgYOuB47ke

Logs: debug.zip

@tomdodd4598
Copy link
Owner

Hmm, this seems like a tricky one to get around totally, but I have a potential idea to avoid the conversion of the collection of chunks into an array. I'll add it to the next version of NCO, but it might be a bit of time before NCO as a whole is stable again.

I can also add the config option you describe to disable TEs contributing to chunk radiation :)

@tomdodd4598
Copy link
Owner

Sorted, hopefully it works!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants