Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for country flags #2

Open
sreuter opened this issue Jan 19, 2021 · 2 comments
Open

Add support for country flags #2

sreuter opened this issue Jan 19, 2021 · 2 comments
Labels
bug Something isn't working good first issue Good for newcomers help wanted Extra attention is needed

Comments

@sreuter
Copy link

sreuter commented Jan 19, 2021

Awesome work! Any special reason why country flags are not supported?

@tomekkleszcz
Copy link
Owner

Hi, This is an oversight on my part. I will implement the country flags in my free time. :)

@tomekkleszcz tomekkleszcz added bug Something isn't working good first issue Good for newcomers help wanted Extra attention is needed labels Jan 25, 2021
@sreuter
Copy link
Author

sreuter commented Jan 30, 2021

Awesome, we should be able to piggyback on https://github.com/twitter/twemoji-parser/blob/master/src/lib/regex.js I assume. It doesn't work as a direct replacement for your current regex tho, as reactStringReplace seems to want it in a different format.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants