Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

image.py: fix old-style(?) relative import statement #366

Merged
merged 2 commits into from Dec 23, 2017

Conversation

tkluck
Copy link
Contributor

@tkluck tkluck commented Dec 22, 2017

This fixes #365. I can't actually find when this syntax became illegal, but this replacement works both in Python 2.7 and 3.6 whereas the original doesn't.

As I wrote in #365, this patch unbreaks installs under versions of pip that have a hard dependency on the py->pyc step succeeding.

@coveralls
Copy link

coveralls commented Dec 22, 2017

Coverage Status

Coverage decreased (-1.07%) to 81.198% when pulling 23a29b4 on tkluck:master into 1650815 on tomerfiliba:master.

@henryiii
Copy link
Collaborator

Just to make sure that this doesn't break again, I'll add an import for image to the tests.

@coveralls
Copy link

coveralls commented Dec 23, 2017

Coverage Status

Coverage decreased (-0.6%) to 81.684% when pulling 5f2fee3 on tkluck:master into 1650815 on tomerfiliba:master.

2 similar comments
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.6%) to 81.684% when pulling 5f2fee3 on tkluck:master into 1650815 on tomerfiliba:master.

@coveralls
Copy link

coveralls commented Dec 23, 2017

Coverage Status

Coverage decreased (-0.6%) to 81.684% when pulling 5f2fee3 on tkluck:master into 1650815 on tomerfiliba:master.

@henryiii henryiii merged commit 9f73a29 into tomerfiliba:master Dec 23, 2017
@henryiii
Copy link
Collaborator

henryiii commented Dec 23, 2017

Thanks!

@tkluck
Copy link
Contributor Author

tkluck commented Dec 23, 2017

Thanks @henryiii ! Can I request a (point) release for this one? It's blocking my install in production.

@henryiii
Copy link
Collaborator

Sure. I’m traveling for Christmas so might not be immediate. I’d like to fix the slow load/added requirement from the translation addition too. ~1 week?

@tkluck
Copy link
Contributor Author

tkluck commented Dec 23, 2017

That would be marvellous. Thanks! Let me know if I can help.

@henryiii
Copy link
Collaborator

Done, github and pypi are one 1.6.5, and conda-forge should follow soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SyntaxError in plumbum/cli/image.py
3 participants