Ensuring that we get a server we can connect to from the list. #220
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…stead of the first element of the list of all registered servers.
|
Hi, thanks for your interest. Can you clean up a few things before merge:
|
coldfix
added a commit
that referenced
this pull request
Jul 28, 2017
The one that you were getting and trying to avoid due to a server being down, i.e. the purpose of this PR. Why did you push a random new version? Nevermind, I'll clean it up. |
|
Sorry, I needed a new version locally to force and update over my existing installation. It was not supposed to be included in the pull request. I will clean up and send you an updated patch directly.
…Sent from my iPad
On Jul 28, 2017, at 6:18 AM, Thomas G. <notifications@github.com<mailto:notifications@github.com>> wrote:
what exception should we use (what will connect_stream throw)?
The one that you were getting and trying to avoid due to a server being down, i.e. the purpose of this PR.
Why did you push a random new version?
Nevermind, I'll clean it up.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub<#220 (comment)>, or mute the thread<https://github.com/notifications/unsubscribe-auth/AIF2Y7NLxa2cd0CCjKAyM4pSiIAIHxYBks5sScN_gaJpZM4N-k0e>.
|
|
It's okay. Don't bother I already merged a cleaned up version. |
|
Thank you. Sorry for the inconvenience. I will pull in your changes directly.
…Sent from my iPad
On Jul 28, 2017, at 6:47 AM, Thomas G. <notifications@github.com<mailto:notifications@github.com>> wrote:
It's okay. Don't bother I already merged a cleaned up version.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub<#220 (comment)>, or mute the thread<https://github.com/notifications/unsubscribe-auth/AIF2YxmuyHBLXF_YON7ZPanH020Xm7f_ks5sScpcgaJpZM4N-k0e>.
|
coldfix
added a commit
that referenced
this pull request
Aug 7, 2017
- Fix refcount leakage when unboxing from cache (#196) - Fix TypeError when dispatching exceptions on py2 (unicode) - Respect ``rpyc_protocol_config`` for default Service getattr (#202) - Support unix domain sockets (#100,#208) - Use first accessible server in ``connect_by_service`` (#220) - Fix deadlock problem with logging (#207,#212)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Registry client returns first registry server it could connect to (instead of the first element of the list of all registered servers).