Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rpyc_classic.py and rpyc_registry.py files no longer in Python Scripts DIR #505

Open
another-salad opened this issue Aug 10, 2022 · 5 comments
Assignees
Labels
Triage Investigation by a maintainer has started

Comments

@another-salad
Copy link

Hello, sorry this might be a stupid question/bug report.

In RPyC 5.2.3 I can see the following two executables in the Python Scripts DIR:

image

In all previous version of RPyC I have used (5.0, 5.1, 4.x) these have always been python (.py) files.
Can I just confirm if this change is expected?

Thanks!

  • rpyc version: 5.2.3
  • python version: 3.9.7
  • operating system: Windows 10
@another-salad another-salad changed the title rpyc_classic.py file no longer in Python Scripts DIR rpyc_classic.py and rpyc_registry.py files no longer in Python Scripts DIR Aug 10, 2022
@another-salad
Copy link
Author

I assume this is likely related to: #503

@comrumino
Copy link
Collaborator

So, I did change the build process. Now, it very well could be a windows thing for hatch. Are there any other script entry points? Based on my configuration, I would expect there to be both entry points.

@comrumino comrumino self-assigned this Aug 25, 2022
@comrumino comrumino added the Triage Investigation by a maintainer has started label Aug 25, 2022
@another-salad
Copy link
Author

Hello,

I did a quick test at work today with a fresh install of 5.2.3 on a Windows 10 machine, and I witnessed the same behaviour. Neither rpyc_classic.py or rpyc_registry.py were in the Python Scripts directory, but the executables were (as well as entry points from other packages).

I'll try and repo this over the weekend on one of my Windows 10 machines if I get the chance. Is there an install log or anything useful that I can provide?

@another-salad
Copy link
Author

With a fresh install of Python 3.10.6 on a Windows 10 machine I also saw the same behaviour (print screen of scripts directory):
image

@comrumino
Copy link
Collaborator

I will have to review pyproject.toml settings and documentation. If you want to toy around with hatch in the mean time, the build steps
7. Install hatch: pyenv exec pip install hatch
8. Clean up any old build artifacts: git clean -Xf -- dist/
9. Create a wheel package: pyenv exec hatch -v build

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Triage Investigation by a maintainer has started
Projects
None yet
Development

No branches or pull requests

2 participants