Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update pdf.css with new workshop style #80

Open
3 tasks
Shrinks99 opened this issue Dec 18, 2018 · 3 comments
Open
3 tasks

Update pdf.css with new workshop style #80

Shrinks99 opened this issue Dec 18, 2018 · 3 comments
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@Shrinks99
Copy link
Member

Shrinks99 commented Dec 18, 2018

pdf.css should be brought in line with the new workshop style.

  • New typography
  • Update a mesh graphics used in PDFs
  • New style for in-line and blocks of code

All content is intended for printing in black and white but colour can still be used here and there as long as enough contrast is provided.

@Shrinks99 Shrinks99 added enhancement New feature or request ssbc Supported by ssbc grant labels Dec 18, 2018
@Shrinks99 Shrinks99 added this to To do in Remark Slide Conversion via automation Dec 18, 2018
@Shrinks99 Shrinks99 self-assigned this Dec 18, 2018
@Shrinks99 Shrinks99 moved this from To do to In progress in Remark Slide Conversion Jan 16, 2019
@Shrinks99
Copy link
Member Author

This is proving to be a little trickier than expected, markdown-pdf does not seem to support the font-weight CSS property and this is a huge typographical bummer. Until this is fixed I am unable to update pdf.css to match the new font choices and it's actually a miracle that my 10 minutes of untested code works as well as it does.

@Shrinks99 Shrinks99 removed this from In progress in Remark Slide Conversion Mar 1, 2019
@Shrinks99 Shrinks99 removed the ssbc Supported by ssbc grant label Mar 5, 2019
@Shrinks99
Copy link
Member Author

@benhylau Because of the flaws in markdown-pdf (and the fact that it looks like they're not getting fixed any time soon we may want to have a look at mdpdf instead. It seems to work in almost exactly the same way but is also a bit more fully featured.

@benhylau benhylau self-assigned this Mar 6, 2019
@benhylau
Copy link
Member

benhylau commented Mar 6, 2019

Will looK!

@Shrinks99 Shrinks99 added this to the 1.0 milestone Mar 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants