Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Remark dependencies to install-dependencies.sh #81

Closed
2 tasks done
Shrinks99 opened this issue Dec 18, 2018 · 2 comments
Closed
2 tasks done

Add Remark dependencies to install-dependencies.sh #81

Shrinks99 opened this issue Dec 18, 2018 · 2 comments
Assignees
Labels
enhancement New feature or request ssbc Supported by ssbc grant

Comments

@Shrinks99
Copy link
Member

Shrinks99 commented Dec 18, 2018

  • Decktape
  • do we need a web server? (EDIT: nope! Thanks Ben!)
@Shrinks99 Shrinks99 added enhancement New feature or request ssbc Supported by ssbc grant labels Dec 18, 2018
@Shrinks99 Shrinks99 added this to To do in Remark Slide Conversion via automation Dec 18, 2018
@Shrinks99 Shrinks99 moved this from To do to In progress in Remark Slide Conversion Dec 18, 2018
@benhylau
Copy link
Member

benhylau commented Dec 21, 2018

No we don't need a web server, as long as you use the flag --chrome-arg=--allow-file-access-from-files like such:

decktape remark index.html out.pdf --chrome-arg=--allow-file-access-from-files

I was able to PDF my personal remark slides like this. But it fails with the following on your branch, perhaps because of the relative paths to remark.min.js in the root directory:

❯❯❯ decktape remark module-1.html out.pdf --chrome-arg=--allow-file-access-from-files
Loading page file:///<<PATH_TO>/p2p-internet-workshop/module-1/module-1.html ...

Page error: Error
    at XMLHttpRequest.s.onload (file:///<PATH_TO>/p2p-internet-workshop/remark.min.js:17:19540)
Loading page finished with status: 0
Remark JS plugin activated
Printing slide #0       (  1/ ?) ...
Printed 1 slides

Perhaps it is due to the relative paths you have. All the remark files should be contained in the presentation directory, even though that could duplicate the remark files I expect them to be reasonably sized... that should solve the problem. It would also avoid how your branch currently has all these remark files spilled all over the root directory.

@Shrinks99
Copy link
Member Author

Closed in 94ac958!

Remark Slide Conversion automation moved this from In progress to Done Jan 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request ssbc Supported by ssbc grant
Projects
No open projects
Development

No branches or pull requests

2 participants