Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistent URLs built from :web-home #6

Open
fxt opened this issue Apr 29, 2011 · 0 comments
Open

Inconsistent URLs built from :web-home #6

fxt opened this issue Apr 29, 2011 · 0 comments

Comments

@fxt
Copy link
Contributor

fxt commented Apr 29, 2011

The :wiki-url built for the namespace-index-info does not insert a "/" between the :web-home and the namespace file name (it assumes the given :web-home has a trailing "/").
The :wiki-url built for the var-index-info does insert a "/" between the :web-home and the var file name (it assumes the given :web-home does not end in "/").

You can easily see it in the generated index.clj. Search for :wiki-url. Either the ones in the :namespaces section have one "/" correctly and the ones in the :vars section have a "//" in the middle of the URL, or the former are missing the "/" and the latter are correct.

Inserting "/" at line 493 of build_html.clj would fix the problem.
Even better, adding a normalization step to turn "//" and things like "/./" into "/" would make things even cleaner.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant