Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

change type conversion code to fix bug on fp16 #27

Closed
wants to merge 1 commit into from
Closed

change type conversion code to fix bug on fp16 #27

wants to merge 1 commit into from

Conversation

TobiasLee
Copy link

There is an implicit float16 -> float32 conversion in the original code if net weights are float16

p.data = w + torch.Tensor(d).type(type(w))

thus results in inaccurate loss computation.
The following code can avoid this problem since it take the exact w.dtype when doing the conversion

p.data = w + torch.Tensor(d).type_as(w.dtype)

@TobiasLee
change type conversion code to fix bug on fp16
50d19a4 
There is an implicit float16 -> float32 conversion in the original code **if net weights are float16**
```python3
p.data = w + torch.Tensor(d).type(type(w))
```
@TobiasLee TobiasLee closed this Mar 6, 2020
@TobiasLee
Copy link
Author

need further test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@TobiasLee